-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation]: Cleanup docker installation docs #2981
base: main
Are you sure you want to change the base?
Conversation
35cc05f
to
f159b18
Compare
- move apple silicon specifics from ubuntu to OSX section - fix docker compose commands - adjust heading level for Docker section Signed-off-by: Panni, Lukas <[email protected]>
Can't comment on the Sillicon stuff, but 👍 on the rest |
an additional change that could be useful in this PR (since changes are already being made to docker docs): i did notice that the docker build command on this page has a filepath slightly wrong (FYI im using podman on a debian based system), it should be: also the three options available for subdirectories are now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one small change for clarity related to the environment.txt being an example of the contents for .env
file that Docker looks for.
4. `sudo docker build -t augur-new -f docker/backend/Dockerfile .` | ||
5. `sudo docker compose --env-file ./environment.txt --file docker-compose.yml up` to run the database in a Docker Container or | ||
`sudo docker compose --env-file ./environment.txt --file docker-compose.yml up` to connect to an already running database. | ||
`sudo docker compose --env-file ./environment.txt --file docker-compose-externalDB.yml up` to connect to an already running database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tracks with improvements and changes recently made by @cdolfi . Thanks!
Description
Docs:
Notes for Reviewers
Probably the docker documentation needs to be consolidated entirely.
Signed commits