feature: Periodically clean up invalid blade #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xcaspar
reviewed
Nov 16, 2020
cmd/manager/main.go
Outdated
| logrus.Infof("start periodically clean up blade ticker, interval: %d", time.Duration(duration.Seconds())) | ||
| ticker := time.NewTicker(time.Second * time.Duration(duration.Seconds())) | ||
| for range ticker.C { | ||
| cli.List(context.TODO(), results, &client.ListOptions{}) |
There was a problem hiding this comment.
It's better to add status filter in list options.
tiny-x
force-pushed
the
feature-operator-52
branch
3 times, most recently
from
d533f29 to
c52c55e
Compare
Signed-off-by: tiny.x <[email protected]>
tiny-x
force-pushed
the
feature-operator-52
branch
from
c52c55e to
d721a79
Compare
xcaspar
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tiny.x [email protected]
Describe what this PR does / why we need it
Periodically clean up invalid blade
Does this pull request fix one issue?
#52
Describe how you did it
Describe how to verify it
Special notes for reviews