Skip to content

Normalize flags and logs in the operator #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2020
Merged

Conversation

xcaspar
Copy link
Member

@xcaspar xcaspar commented May 26, 2020

Describe what this PR does / why we need it

chaosblade-io/chaosblade#356

Does this pull request fix one issue?

Describe how you did it

  1. Update
--image-repo string                ChaosBlade image repository, default value is registry.cn-hangzhou.aliyuncs.com/chaosblade/chaosblade-tool (default "registry.cn-hangzhou.aliyuncs.com/chaosblade/chaosblade-tool")
--blade-version string             Chaosblade image version, default value is latest (default "latest")
--pull-policy string               Pull image policy, default value is IfNotPresent (default "IfNotPresent")
--namespace string                 the kubernetes namespace which chaosblade operator deployed (default "kube-system")

to

--chaosblade-image-repository string    Image repository of chaosblade tool (default "chaosbladeio/chaosblade-tool")
--chaosblade-version string             Chaosblade tool version (default "0.6.0")
--chaosblade-image-pull-policy string   Pulling policy of chaosblade image, default value is IfNotPresent (default "IfNotPresent")
--chaosblade-namespace string           The kubernetes namespace which chaosblade tool pods deployed (default "kube-system")
  1. Replace sigs.k8s.io/controller-runtime/pkg/runtime/log to github.com/sirupsen/logrus as the default logger.

Describe how to verify it

Deploy and test it.

Special notes for reviews

@xcaspar xcaspar added the type/enhancement New feature or request label May 26, 2020
@xcaspar xcaspar added this to the v0.6.0 milestone May 26, 2020
@xcaspar xcaspar requested a review from RinaisSuper May 26, 2020 11:25
@RinaisSuper RinaisSuper merged commit ad9af1d into master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants