fix: failing rdev updates #5972
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5972 +/- ##
=======================================
Coverage 85.83% 85.83%
=======================================
Files 196 196
Lines 15378 15378
=======================================
Hits 13200 13200
Misses 2178 2178
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| | select(.imageTag==$STACK_NAME)][0].imageDigest'`) | ||
| done | ||
| echo "ECR_REPOS=${ECR_REPOS[@]}" >> $GITHUB_OUTPUT | ||
| echo "IMAGE_DIGESTS=${IMAGE_DIGESTS[@]}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Does this code run each repo on each matrix slice? Yes. But that doesn't matter. It's quick, and whenever an image digest is missing, it just ignores that. Deletion attempts of images that don't exist aren't a problem.
There was a problem hiding this comment.
Can update to be a bit more streamlined later, but that will require separating out into a different job and configuring outputs. Might consider making it its own workflow later. Minor tech debt for another day.
There was a problem hiding this comment.
Nvm, went ahead and fixed this
There was a problem hiding this comment.
Nvm, went ahead and fixed this
| @@ -28,6 +28,36 @@ permissions: | |||
| pull-requests: write | |||
|
|
|||
| jobs: | |||
| get_previous_image_digests: | |||
There was a problem hiding this comment.
Nitpick: the convention is to use dashes and not underscores.
There was a problem hiding this comment.
the problem is we need to access outputs by job name
| registry: ${{ secrets.ECR_REPO }} | ||
| - name: Get previous image digests for each repo | ||
| id: get_digests | ||
| run: | |
There was a problem hiding this comment.
This is potentially dangerous since if you add another component, we most certainly won't update the list. I don't think there is an easy way to parse them though.
Reason for Change
Changes
Testing steps
Notes for Reviewer