Skip to content

chore(wmg): fix publication format #5969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 13, 2023
Merged

Conversation

kaloster
Copy link
Contributor

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #5969 (e7f5b94) into main (b16321b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5969   +/-   ##
=======================================
  Coverage   85.83%   85.83%           
=======================================
  Files         196      196           
  Lines       15378    15378           
=======================================
  Hits        13200    13200           
  Misses       2178     2178           
Flag Coverage Δ
unittests 85.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kaloster kaloster requested a review from tihuan October 13, 2023 13:59
Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating the test too 👍

Is there an opportunity to share the citation util function with Collections page, so we have single source of truth?

Thank you!

@kaloster kaloster merged commit b88c6ac into main Oct 13, 2023
@kaloster kaloster deleted the kaloster/fix-publication-format-5484 branch October 13, 2023 14:34
Bento007 pushed a commit that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants