test: use smoke test account to seed db for smoke tests #5943
Conversation
This commit modifies the BaseFunctionalTestCase class to allow the caller to specify a `smoke_tests` flag. If True, the class will initialized (seed) the data using the test account for smoke tests, which is [email protected], instead of the test account for functional tests, which is [email protected]
Deployment Summary
|
This commit un-skips the smoke tests that require a user token
Codecov Report
@@ Coverage Diff @@
## main #5943 +/- ##
=========================================
+ Coverage 0 85.83% +85.83%
=========================================
Files 0 196 +196
Lines 0 15378 +15378
=========================================
+ Hits 0 13200 +13200
- Misses 0 2178 +2178
Flags with carried forward coverage won't be shown. Click here to find out more. see 196 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -31,7 +31,7 @@ describe("Collection Revision @loggedIn", () => { | |||
| * TODO(#5666): Enable this test once #5666 is resolved | |||
| * https://app.zenhub.com/workspaces/single-cell-5e2a191dad828d52cc78b028/issues/gh/chanzuckerberg/single-cell-data-portal/5666 | |||
| */ | |||
| test.skip("starts a revision", async ({ page }) => { | |||
| test("starts a revision", async ({ page }) => { | |||
There was a problem hiding this comment.
@tihuan re-added these two tests but it's failing 😞
not obvious to me where the issue is since the smoke test initialization is now using the test user acct, and this e2e test uses (or appears to use) the same test user credentials...
There was a problem hiding this comment.
I know you specifically did not request for me to make this change as part of the issue but it really did appear that it should be that simple (to my eye)
I can revert, and simply make the smoke test db initialization change, and then you can figure out how to reinstate the tests if you know what I'm missing
There was a problem hiding this comment.
Hey Dan! Thanks so much for enabling the test! That totally makes sense and serves as a way to ensure data seeding works 😆
So far it seems like the smoke test account is not seeing any writable published collections it can pick from 🤔
And if it's helpful, maybe it'd help to manually log into the smoke test account in RDEV to check it yourself too!
Another thing is that e2e test result is stored under GHA summary, and you can download it under "logged in test result" like so:
and unzipping the files will give you this directory:
The trace.zip is especially useful, to use it, please check out instructions here!
https://github.com/chanzuckerberg/single-cell-data-portal/tree/main/frontend/tests
There was a problem hiding this comment.
Thanks Timmy! I'll check this out
There was a problem hiding this comment.
Perfect! Thanks so much for your help with this, Dan 🙏 !
There was a problem hiding this comment.
Ah I see. The issue here is we need additional improvements to the seeding script in addition to changing the existing collections to belong to the test user account rather than the func test account.
This commit modifies the BaseFunctionalTestCase class to allow the caller to specify a
smoke_testsflag. If True, the class will initialized (seed) the data using the test account for smoke tests, which is [email protected], instead of the test account for functional tests, which is [email protected]Reason for Change
Changes
[email protected](rather than the functional test user account[email protected]) to seed the database ahead of smoke tests[email protected]Testing steps
Notes for Reviewer