feat: Add a citation button to pages #1856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rainandbare it works on the stack, so that solves it for now 😄 |
rainandbare
reviewed
Jun 20, 2025
| @@ -25,7 +26,7 @@ export function DatasetHeader() { | |||
| return ( | |||
| <PageHeader | |||
| actions={ | |||
| <div> | |||
| <div className="flex items-center gap-2.5"> | |||
There was a problem hiding this comment.
nit: let's use gap-sds-s to keep our spacing scale explicitly in line with sds recommendations!
Though I can see you got it from RunHeader, nice detective work, we would have to swap it there too.
There was a problem hiding this comment.
Oh I see! Thanks, fixed it in both places.
There was a problem hiding this comment.
@rainandbare hopefully this is what you meant!
rainandbare
approved these changes
Jun 20, 2025
|
@dgmccart Please take a look when you have the time. Thanks! |
dgmccart
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be some cleanup to be done later, as I've based this implementation on the View Tomogram button.
EDIT:
The implementation of plausible tracking is still pending.Done.Closes #1847