-
Notifications
You must be signed in to change notification settings - Fork 20
Config + DebugMode rename (breaking) #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The name is okay to me, but that means we should probably not export it because it is too generic. What is the plan for the default execution mode (i.e. true/false for debugging mode)? If the default is true, it feels too lengthy to type |
Codecov ReportAttention: Patch coverage is
|
Agreed -- I won't export it.
The default is debug mode off, so people will just have to write AutoMooncake(; config=Mooncake.Config()) to get the default fast mode. |
Performance Ratio:
|
I'm going to hold off merging this until the ADType PR looks good to go. |
ADTypes PR is merged, so I'm going to release this. |
Addresses #215 and further's the renaming process.
@yebai are you happy with just calling the object
Config
?