Skip to content

Remove sov-tx chainid, Fix sov-tx signature #2387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: nightly
Choose a base branch
from
Open

Conversation

kpp
Copy link
Contributor

@kpp kpp commented May 23, 2025

@kpp kpp requested a review from eyusufatik as a code owner May 23, 2025 06:30
@auto-assign auto-assign bot requested a review from rakanalh May 23, 2025 06:30
Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 52.63158% with 18 lines in your changes missing coverage. Please review.

Project coverage is 84.7%. Comparing base (8dff564) to head (6c0d70d).
Report is 1 commits behind head on nightly.

Files with missing lines Patch % Lines
.../rollup-interface/src/state_machine/transaction.rs 51.3% 18 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/sequencer/src/runner.rs 93.7% <100.0%> (ø)
.../rollup-interface/src/state_machine/transaction.rs 71.2% <51.3%> (-21.2%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eyusufatik
Copy link
Member

Good solution. Should we make this when we do a network upgrade?

@kpp kpp force-pushed the kpp/sov_tx_update branch from fa36419 to 6c0d70d Compare May 23, 2025 16:56
@eyusufatik eyusufatik added the HOLD-MERGE PR is not draft but should not be merged yet label May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HOLD-MERGE PR is not draft but should not be merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transaction stores borsh serialized signature
2 participants