Skip to content

feat: update SP1 to v4 #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: nightly
Choose a base branch
from
Open

feat: update SP1 to v4 #2168

wants to merge 11 commits into from

Conversation

leruaa
Copy link

@leruaa leruaa commented Mar 26, 2025

Description

Here a summary of the work that has been done in this PR:

  • Updated SP1 to v4.1.3
  • Updated the SP1 guest to catch up the work done since the previous implementation
  • Added 2 mutually exclusive features: sp1 and r0, as there are duplicate syscalls definitions when both sp1-zkvm and risc0-zkvm are used
  • Added the ability to send multiple inputs to the guest, as SP1 dosn't currently allow to read all the input from a stream.
  • Added a cycle count benchmark for SP1

Linked Issues

  • Fixes # (issue, if applicable)
  • Related to # (issue)

Testing

Describe how these changes were tested. If you've added new features, have you added unit tests?

Docs

Describe where this code is documented. If it changes a documented interface, have the docs been updated?

@leruaa leruaa marked this pull request as ready for review March 26, 2025 09:17
@leruaa leruaa requested a review from eyusufatik as a code owner March 26, 2025 09:17
@auto-assign auto-assign bot requested a review from yaziciahmet March 26, 2025 09:17
@leruaa leruaa force-pushed the sp1-adapter branch 3 times, most recently from eddc6b7 to 2acf606 Compare April 2, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant