Skip to content

Set supported max opset version #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2019
Merged

Conversation

disktnk
Copy link
Member

@disktnk disktnk commented Sep 27, 2019

Use maximum supported opset version when opset is not set.

@disktnk disktnk added this to the 1.5.1 milestone Sep 27, 2019
@codecov-io
Copy link

codecov-io commented Sep 27, 2019

Codecov Report

Merging #237 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   91.37%   91.38%   +0.01%     
==========================================
  Files          24       24              
  Lines        1611     1613       +2     
==========================================
+ Hits         1472     1474       +2     
  Misses        139      139
Impacted Files Coverage Δ
onnx_chainer/export.py 93.2% <100%> (+0.02%) ⬆️
onnx_chainer/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b43993f...89fc7b7. Read the comment docs.

@disktnk disktnk requested a review from shinh September 28, 2019 02:19
Copy link
Member

@shinh shinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disktnk disktnk merged commit 6897e06 into chainer:master Oct 1, 2019
@disktnk disktnk deleted the fix/max-opset branch October 1, 2019 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants