Skip to content

Drop parameters argument from converters #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

disktnk
Copy link
Member

@disktnk disktnk commented Jul 31, 2019

parameters is included in context.

before

def convert_func(..., context, parameters):
    parameters.append(p)

after

def convert_fun(..., context):
    context.parameters.append(p)

@disktnk disktnk added this to the 1.5.0 milestone Jul 31, 2019
@disktnk
Copy link
Member Author

disktnk commented Jul 31, 2019

/test

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit f8dd05e:

@codecov-io
Copy link

codecov-io commented Jul 31, 2019

Codecov Report

Merging #212 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
- Coverage   89.88%   89.87%   -0.02%     
==========================================
  Files          24       24              
  Lines        1473     1471       -2     
==========================================
- Hits         1324     1322       -2     
  Misses        149      149
Impacted Files Coverage Δ
onnx_chainer/functions/noise.py 80% <ø> (ø) ⬆️
onnx_chainer/functions/converter.py 100% <ø> (ø) ⬆️
onnx_chainer/functions/loss.py 84% <ø> (ø) ⬆️
onnx_chainer/functions/array.py 90.16% <100%> (ø) ⬆️
onnx_chainer/functions/normalization.py 86.44% <100%> (ø) ⬆️
onnx_chainer/functions/connection.py 89.13% <100%> (ø) ⬆️
onnx_chainer/graph.py 95.65% <100%> (ø) ⬆️
onnx_chainer/functions/pooling.py 88.73% <100%> (ø) ⬆️
onnx_chainer/functions/activation.py 85.48% <100%> (ø) ⬆️
onnx_chainer/functions/math.py 85.71% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1a1abe...f8dd05e. Read the comment docs.

Copy link
Member

@shinh shinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@disktnk disktnk merged commit a75c88b into chainer:master Aug 1, 2019
@disktnk disktnk deleted the fix/del-convert-arg branch August 1, 2019 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants