Skip to content

Support vector on MatMul #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2019
Merged

Support vector on MatMul #196

merged 3 commits into from
Jul 23, 2019

Conversation

disktnk
Copy link
Member

@disktnk disktnk commented Jul 23, 2019

fixes #195

@disktnk disktnk added this to the 1.5.0 milestone Jul 23, 2019
@disktnk disktnk changed the title Support vector on MutMul Support vector on MatMul Jul 23, 2019
@codecov-io
Copy link

codecov-io commented Jul 23, 2019 •
edited
Loading

Codecov Report

Merging #196 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   89.67%   89.72%   +0.05%     
==========================================
  Files          24       24              
  Lines        1394     1402       +8     
==========================================
+ Hits         1250     1258       +8     
  Misses        144      144
Impacted Files Coverage Δ
onnx_chainer/functions/math.py 86.3% <100%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ea443...cdd612c. Read the comment docs.

shinh
shinh approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@shinh shinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

tests/functions_tests/test_maths.py
name = self.op_name.lower()
self.expect(self.model, self.x, name=name)
test_cases = ['matrix', 'vector']
if not self.op_name.startswith('MatMul'):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[optional] I guess it's OK to remove this check?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this means we can skip scalar test? I don't have strong opinion but leave this test case to make sure.

@disktnk disktnk merged commit e7909e1 into chainer:master Jul 23, 2019
@disktnk disktnk deleted the fix/matmul-vector branch July 23, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinh shinh shinh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

IndexError on Matmul
3 participants
@disktnk @codecov-io @shinh