Skip to content

Support group param on Conv/Deconv #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2019
Merged

Conversation

disktnk
Copy link
Member

@disktnk disktnk commented Apr 23, 2019

fixes #156

@disktnk disktnk added this to the 1.4.1 milestone Apr 23, 2019
@disktnk
Copy link
Member Author

disktnk commented Apr 23, 2019

ChainerCI, test this please

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit ac3884f (c8ef72f):

@codecov-io
Copy link

codecov-io commented Apr 23, 2019

Codecov Report

Merging #157 into master will increase coverage by 0.7%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #157     +/-   ##
=======================================
+ Coverage   85.29%    86%   +0.7%     
=======================================
  Files          22     22             
  Lines        1129   1129             
=======================================
+ Hits          963    971      +8     
+ Misses        166    158      -8
Impacted Files Coverage Δ
onnx_chainer/functions/connection.py 89.58% <ø> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0cb9a...b139670. Read the comment docs.

@disktnk
Copy link
Member Author

disktnk commented Apr 23, 2019

ChainerCI, test this please

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit b139670 (0230c74):

Copy link
Member

@shinh shinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks!

@disktnk disktnk merged commit 16c60ec into chainer:master Apr 26, 2019
@disktnk disktnk deleted the fix/conv-group branch April 26, 2019 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ONNX-chainer ignores groups parameter for some convolutions
4 participants