fix to manage each var is renamed or not #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
+ Coverage 85.29% 85.29% +<.01%
==========================================
Files 22 22
Lines 1122 1129 +7
==========================================
+ Hits 957 963 +6
- Misses 165 166 +1
Continue to review full report at Codecov.
|
|
ChainerCI, test this please |
shinh
approved these changes
Apr 23, 2019
onnx_chainer/context.py
Outdated
| Arguments: | ||
| variable (var): target variable | ||
| name (str): name to be exported as ONNX node name | ||
| pinned (bool): if don't want to change the name on subsequent |
There was a problem hiding this comment.
I feel these sentences are a bit redundant. How about "if True, the name will not be overwritten in subsequence process"?
| process, set ``True``. Enable to check the target variable | ||
| is pinned or not by using ``is_pinned``. | ||
| """ | ||
|
|
There was a problem hiding this comment.
I think it's invalid to call set_name for pinned names? How about assert str_id not in self.name_list or not self.name_list[str_id][1]?
|
ChainerCI, test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #154
before
export with
output_names=['out_tanh', 'out_sigmoid'], outputs are renamed but interim node output are not renamed, such asv15after