Move rename_tensor to function_hook #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 83.14% 83.25% +0.11%
==========================================
Files 22 22
Lines 1127 1135 +8
==========================================
+ Hits 937 945 +8
Misses 190 190
Continue to review full report at Codecov.
|
|
If a function is converted nodes are not single, name of intermediate nodes are added "tmp", as
|
shinh
approved these changes
Mar 15, 2019
| self.graph.extend(nodes) | ||
| self.converted_nodes[temp_node_name] = nodes | ||
|
|
||
| def deleted(self, function=None): |
There was a problem hiding this comment.
Could you add a brief comment to explain why we need to use deleted?
shinh
approved these changes
Mar 15, 2019
onnx_chainer/export.py
Outdated
| When renaming an output name, another node can reference the same value | ||
| as input, so the input name must be renamed at once. So this renaming | ||
| process should be run after all functions are converted and this | ||
| `deleted` function is called when function hook is done, means |
There was a problem hiding this comment.
How about "which means all functions are converted"?
onnx_chainer/export.py
Outdated
| `deleted` function is called when function hook is done, means | ||
| completed functions converting. | ||
|
|
||
| If input/output name is given by externally, these given names take |
There was a problem hiding this comment.
Maybe: "names are given externally"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
rename_tensorfunction toFunctionHook.deletedfunction, to be more customizable.FunctionNodename, not ONNX operator name. This change breaks backward compatibilityFunctionNodename as node name