Skip to content

Fix output tensor name #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2019
Merged

Conversation

disktnk
Copy link
Member

@disktnk disktnk commented Mar 13, 2019

When use export_testcase, name of output tensor is not match with model outputs.

@disktnk disktnk added this to the 1.3.4 milestone Mar 13, 2019
Copy link
Member

@shinh shinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix!

assert os.path.isfile(os.path.join(path, 'test_data_set_0', 'output_0.pb'))
input_pb_path = os.path.join(path, 'test_data_set_0', 'input_0.pb')
assert os.path.isfile(input_pb_path)
input_tensor = onnx.load_tensor(input_pb_path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't use onnx.load_tensor in test_output_grad (see line 71). Could you kindly modify it in this chance?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it!

@codecov-io
Copy link

codecov-io commented Mar 13, 2019

Codecov Report

Merging #135 into master will increase coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage    82.9%   83.14%   +0.23%     
==========================================
  Files          22       22              
  Lines        1123     1127       +4     
==========================================
+ Hits          931      937       +6     
+ Misses        192      190       -2
Impacted Files Coverage Δ
onnx_chainer/export.py 90.98% <100%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f1464b...7befeed. Read the comment docs.

@disktnk disktnk merged commit 6abd11b into chainer:master Mar 13, 2019
@disktnk disktnk deleted the fix/output-tensor-name branch March 13, 2019 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants