Stop emitting batch_size for Linear with no bias #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though the original code would be conformant to the ONNX standard, it would be better not to have batch_size in zero bias for Gemm because - users may be able to change batch_size after ONNX generation - generated ONNX will be slightly smaller chainer#103
disktnk
approved these changes
Feb 26, 2019
|
Isn't this case already covering the |
|
Oh, sorry I missed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though the original code would be conformant to the ONNX
standard, it would be better not to have batch_size in zero
bias for Gemm because
#103