fix: set C/C++ language standards per target #1217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgrindel
force-pushed
the
gh1079_c_std_settings2
branch
2 times, most recently
from
9706eb5 to
ca19083
Compare
cgrindel
force-pushed
the
gh1079_c_std_settings2
branch
from
6dba8c0 to
f0a8e2d
Compare
cgrindel
force-pushed
the
gh1079_c_std_settings2
branch
from
f0a8e2d to
0a8f2b2
Compare
brentleyjones
approved these changes
Oct 23, 2024
luispadron
reviewed
Oct 23, 2024
luispadron
approved these changes
Oct 23, 2024
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 6d12d53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the creation of C, C++, ObjC, and ObjC++ targets. For each C-like target in a Swift package, we now create a separate
xxx_librarytarget based upon the type of the source file (e.g. C, C++, ObjC, ObjC++, and assembly). These child libraries are added to a parent library that represents the Swift package target.The goal of this work was to support language standard flags in the Bazel targets generated by
rules_swift_package_manager. If a C language standard is specified in the Swift package, it is applied to the C and ObjC targets. If a C++ language standard is specified, it is applied to the C++ and the ObjC++ targets.Note
The configuration for
rules_xcodeprojin the Firebase example had to be updated to use the sandbox. Without this change, we were seeing duplicate definition errors. If you see these errors in your build, you may need to do the same.Closes #1079 .