Add kubeconform verification of helm charts #280
Conversation
Signed-off-by: Ashley Davis <[email protected]>
cert-manager-prow
bot
added
dco-signoff: yes
| ## Verify that the Helm chart passes a strict check using kubeconform | ||
| ## @category [shared] Generate/ Verify | ||
| verify-helm-kubeconform: $(helm_chart_archive) | $(NEEDS_KUBECONFORM) | ||
| $(HELM) template kubeconform-template-do-not-use $< | $(KUBECONFORM) -strict |
There was a problem hiding this comment.
Yeah that's the [NAME] of the chart:
helm template --help
helm template [NAME] [CHART]
So the rendered output will have the name kubeconform-template-do-not-use in it:
# Source: cert-manager-csi-driver-spiffe/templates/serviceaccount.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
namespace: default
labels:
app.kubernetes.io/name: cert-manager-csi-driver-spiffe
helm.sh/chart: cert-manager-csi-driver-spiffe-v0.0.0
app.kubernetes.io/instance: kubeconform-template-do-not-use <---------------
app.kubernetes.io/version: "v0.0.0"
app.kubernetes.io/managed-by: Helm
name: cert-manager-csi-driver-spiffeThere was a problem hiding this comment.
I'm trying to avoid anyone using that output for anything else - probably wouldn't happen, maybe more confusing than helpful?
There was a problem hiding this comment.
It was a bit confusing, but I understand it better now that you have explained it!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erikgb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
Haha we'll see if I do 😂 |
This catches the issue fixed by cert-manager/csi-driver-spiffe#284 - so it's probably a useful thing to have in the Helm module, globally.