Skip to content

BUGFIX: don't copy the '.' folder #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

BUGFIX: don't copy the '.' folder #272

merged 1 commit into from
Apr 15, 2025

Conversation

inteon
Copy link
Member

@inteon inteon commented Apr 15, 2025

Fixes a bug introduced in #269.
We were also selecting the root directory (.) and copying that folder.

Old command:

find . -maxdepth 1 -not \( -path "./_bin" -prune \)
.
./.github
./modules
./tests
./OWNERS
./bootstrap.sh
./_upgrade
./scripts
./.git
./.gitignore
./LICENSE
./upgrade_all_repos.sh
./README.md
./Makefile

New command:

find . -maxdepth 1 -not \( -path "./_bin" \) -not \( -path "." \)
./.github
./modules
./tests
./OWNERS
./bootstrap.sh
./_upgrade
./scripts
./.git
./.gitignore
./LICENSE
./upgrade_all_repos.sh
./README.md
./Makefile

This likely caused #269 (comment)

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2025
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Makes sense to me!

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2025
@cert-manager-prow cert-manager-prow bot merged commit 63de69c into main Apr 15, 2025
3 of 4 checks passed
@SgtCoDFish SgtCoDFish deleted the bugfix_verify branch April 15, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants