This repository was archived by the owner on Nov 7, 2022. It is now read-only.
Add trace head-sampling #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
requested review from
owais,
flands,
tigrannajaryan,
rghetia and
songy23
This is to complete the sampling feature since OC Service already offers tail-sampling. This is implemented using an extra hashing as an attempt to avoid bias from trace ID generation and also to correctly spread traces for backends that also do hashing. Tests to enforce hash of different lengths. Make hashing seed configurable
Codecov Report
@@ Coverage Diff @@
## master #583 +/- ##
==========================================
+ Coverage 65.97% 66.41% +0.44%
==========================================
Files 85 86 +1
Lines 5428 5518 +90
==========================================
+ Hits 3581 3665 +84
- Misses 1641 1645 +4
- Partials 206 208 +2
Continue to review full report at Codecov.
|
tigrannajaryan
approved these changes
Jun 19, 2019
pjanotti
pushed a commit
to pjanotti/opentelemetry-service
that referenced
this pull request
Jun 19, 2019
Cherry-picking census-instrumentation/opencensus-service#583 from OC. * Add trace head-sampling This is to complete the sampling feature since OC Service already offers tail-sampling. This is implemented using an extra hashing as an attempt to avoid bias from trace ID generation and also to correctly spread traces for backends that also do hashing. Tests to enforce hash of different lengths. Make hashing seed configurable * Direct recommendation about hash seeding setting * More precise wording for hash-seed comment
pjanotti
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Jun 19, 2019
Cherry-picking census-instrumentation/opencensus-service#583 from OC. * Add trace head-sampling This is to complete the sampling feature since OC Service already offers tail-sampling. This is implemented using an extra hashing as an attempt to avoid bias from trace ID generation and also to correctly spread traces for backends that also do hashing. Tests to enforce hash of different lengths. Make hashing seed configurable * Direct recommendation about hash seeding setting * More precise wording for hash-seed comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to complete the sampling feature since OC Service already offers tail-sampling. This is implemented using an extra hashing as an attempt to avoid bias from trace ID generation and also to correctly spread traces for backends that also do hashing.