This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Propagation-Jaeger: Enforce strictNullChecks and noUnusedLocals #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
draffensperger and
justindsmith
as code owners
mayurkale22
force-pushed
the
enforce_strictNullcheck_jaeger_prop
branch
from
3a355c5 to
cdaa308
Compare
| * null. | ||
| * @param value | ||
| */ | ||
| const isHex: ValidationFn = (value: string): boolean => { |
There was a problem hiding this comment.
Could this be a function declaration function isHex rather than an expression? Same for isNotAllZeros, isLength and compose below.
There was a problem hiding this comment.
I will handle this in separate PR.
|
|
||
| it('should return null when header is undefined', () => { | ||
| // tslint:disable-next-line | ||
| const headers = {} as any; |
There was a problem hiding this comment.
Could you specify a type for headers here? Maybe an object whose keys are strings and values are string|undefined?
packages/opencensus-propagation-jaeger/test/test-jaeger-format.ts
Outdated
Show resolved
Hide resolved
mayurkale22
force-pushed
the
enforce_strictNullcheck_jaeger_prop
branch
from
cdaa308 to
3d8f43b
Compare
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
+ Coverage 95.01% 95.03% +0.02%
==========================================
Files 147 147
Lines 9545 9567 +22
Branches 679 680 +1
==========================================
+ Hits 9069 9092 +23
+ Misses 476 475 -1
Continue to review full report at Codecov.
|
draffensperger
approved these changes
Mar 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #348. 2 more packages to go, 20 done so far.