Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

Add support for Binary Format serializer for TagMap #431

Merged
merged 3 commits into from
Mar 21, 2019
Merged

Add support for Binary Format serializer for TagMap #431

merged 3 commits into from
Mar 21, 2019

Conversation

mayurkale22
Copy link
Member

Fixes #326

@mayurkale22 mayurkale22 requested a review from songy23 March 19, 2019 06:02
@codecov-io
Copy link

codecov-io commented Mar 19, 2019 •
edited
Loading

Codecov Report

Merging #431 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
+ Coverage   94.88%   94.93%   +0.04%     
==========================================
  Files         140      144       +4     
  Lines        9294     9432     +138     
  Branches      671      672       +1     
==========================================
+ Hits         8819     8954     +135     
- Misses        475      478       +3
Impacted Files Coverage Δ
src/tags/propagation/variant-encoding.ts 95% <0%> (ø)
test/test-variant-encoding.ts 100% <0%> (ø)
src/tags/propagation/binary-serializer.ts 96.36% <0%> (ø)
test/test-binary-serializer.ts 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dae581...bccf135. Read the comment docs.

@mayurkale22
fix review comments
73521b9 
1. Add comments for MSB and REST constants
2. Remove VERSION_ID_OFFSET -> VERSION_ID_INDEX and b -> currentByte
3. Add backwards-compatible check on versionId
@mayurkale22
Add tests for the varint encoding/decoding
bccf135
@mayurkale22 mayurkale22 mentioned this pull request Mar 19, 2019
Closed
@mayurkale22 mayurkale22 merged commit 04f1fee into census-instrumentation:master Mar 21, 2019
@mayurkale22 mayurkale22 deleted the binary_format_serializer_tags branch March 21, 2019 01:29
@mayurkale22 mayurkale22 mentioned this pull request Mar 25, 2019
Merged
@mayurkale22 mayurkale22 mentioned this pull request Apr 3, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@draffensperger draffensperger draffensperger approved these changes

@songy23 songy23 songy23 approved these changes

@justindsmith justindsmith Awaiting requested review from justindsmith

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mayurkale22 @codecov-io @draffensperger @songy23 @googlebot