Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

Exporter/Instana: Enforce strictNullChecks and noUnusedLocals #390

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ All notable changes to this project will be documented in this file.
- Enforce `--strictNullChecks` and `--noUnusedLocals` Compiler Options on [opencensus-instrumentation-http], [opencensus-instrumentation-grpc] and [opencensus-propagation-tracecontext] packages.
- Enforce `--strictNullChecks` and `--noUnusedLocals` Compiler Options on [opencensus-exporter-zipkin] packages.
- Add NoRecordRootSpan, NoRecordSpan and NoRecordSpanBase.
- Enforce `--strictNullChecks` and `--noUnusedLocals` Compiler Options on [opencensus-exporter-instana] package.
- Add an API `globalStats.unregisterExporter()`.

## 0.0.9 - 2019-02-12
Expand Down
8 changes: 6 additions & 2 deletions packages/opencensus-exporter-instana/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
# OpenCensus Instana Exporter for Node.js
# OpenCensus Instana Trace Exporter
[![Gitter chat][gitter-image]][gitter-url]

OpenCensus Instana Exporter allows the user to send collected traces with [OpenCensus Node.js](https://github.com/census-instrumentation/opencensus-node) to [Instana](https://www.instana.com/).
OpenCensus Instana Trace Exporter allows the user to send collected traces with [OpenCensus Node.js](https://github.com/census-instrumentation/opencensus-node) to [Instana](https://www.instana.com/).

[Instana](http://www.instana.com/) is a distributed
tracing system. Instana provides AI Powered Application and Infrastructure Monitoring, allowing you to deliver Faster With Confidence, and automatic Analysis and Optimization.

This project is still at an early stage of development. It's subject to change.

Expand All @@ -27,6 +30,7 @@ tracing.start({

## Useful links
- For more information on OpenCensus, visit: <https://opencensus.io/>
- For Instana project at https://www.instana.com/
- To checkout the OpenCensus for Node.js, visit: <https://github.com/census-instrumentation/opencensus-node>
- For help or feedback on this project, join us on [gitter](https://gitter.im/census-instrumentation/Lobby)

Expand Down
2 changes: 1 addition & 1 deletion packages/opencensus-exporter-instana/src/instana.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

import {Exporter, ExporterBuffer, ExporterConfig, RootSpan, Span, SpanKind} from '@opencensus/core';
import {Exporter, ExporterBuffer, ExporterConfig, RootSpan, Span} from '@opencensus/core';
import {logger, Logger} from '@opencensus/core';
import {request} from 'http';

Expand Down
9 changes: 0 additions & 9 deletions packages/opencensus-exporter-instana/test/test-instana.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,9 @@

import {CoreTracer, RootSpan, SpanKind, TracerConfig} from '@opencensus/core';
import * as assert from 'assert';
import * as http from 'http';
import * as mocha from 'mocha';
import * as nock from 'nock';

import {InstanaTraceExporter} from '../src/instana';

/** Interface with request response model */
interface RequestResponse {
statusCode: number;
statusMessage: string;
}

/** Default config for traces tests */
const defaultConfig: TracerConfig = {
samplingRate: 1
Expand Down
6 changes: 4 additions & 2 deletions packages/opencensus-exporter-instana/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
"outDir": "build",
"pretty": true,
"module": "commonjs",
"target": "es6"
"target": "es6",
"strictNullChecks": true,
"noUnusedLocals": true
},
"include": [
"src/**/*.ts",
Expand All @@ -14,4 +16,4 @@
"exclude": [
"node_modules"
]
}
}