This repository was archived by the owner on Dec 23, 2023. It is now read-only.
Add Tracestate into SpanContext. #1359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
codefromthecrypt,
SergeyKanzhelev and
sebright
Codecov Report
@@ Coverage Diff @@
## master #1359 +/- ##
============================================
+ Coverage 83.34% 83.36% +0.02%
- Complexity 1429 1433 +4
============================================
Files 223 223
Lines 6749 6758 +9
Branches 638 638
============================================
+ Hits 5625 5634 +9
Misses 944 944
Partials 180 180
Continue to review full report at Codecov.
|
|
FWIW I like the name as it matches the header. if we do otherwise tempts people to disregard that. |
|
main concerns to consider is if we want this exposed as public api as it will be always available to user. for example it can be propagated package privately.. that is a choice especially as this isnt really a user api. |
kokoro-team
removed
the
kokoro:force-run
songy23
added
tracing
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
songy23
approved these changes
Aug 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One caveat in this PR: Tracestate name seems to not be consistent with the other class names. Maybe TraceState is better (just want to have others opinion).