-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Remove locksmith dependency #37
Conversation
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
- Coverage 94.86% 89.65% -5.21%
==========================================
Files 27 20 -7
Lines 1519 899 -620
==========================================
- Hits 1441 806 -635
- Misses 78 93 +15
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
- Coverage 95.17% 89.73% -5.44%
==========================================
Files 25 19 -6
Lines 1429 906 -523
==========================================
- Hits 1360 813 -547
- Misses 69 93 +24
Continue to review full report at Codecov.
|
fixes #32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a couple minor comments.
Sources/CelyKeychain.swift
Outdated
// Cely-iOS | ||
// | ||
// Created by Fabian Buentello on 8/7/19. | ||
// Copyright © 2019 ChaiOne. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you can update your © for the project. 😛
Sources/CelySecureStorage.swift
Outdated
} | ||
|
||
func get(_ key: String) -> Any? { | ||
if let value = store[key] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is functionally equivalent to return store[key]
No description provided.