Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Swift 4.2 #34

Merged
merged 5 commits into from
May 10, 2019
Merged

Update to Swift 4.2 #34

merged 5 commits into from
May 10, 2019

Conversation

alextall
Copy link
Collaborator

@initFabian The targets were still building against Swift 4.0. I've updated them to 4.2 (which should probably be marked as release 2.1) and will make another PR for 5.0 (which can then be marked as 2.2).

Signed-off-by: Alex Du Bois <[email protected]>
@alextall alextall requested a review from initFabian May 10, 2019 12:31
@initFabian
Copy link
Collaborator

Nice! Thanks for knocking this out. I updated documentation and tests for this build. Please review and verify on your machine everything is 👌

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #34 into master will increase coverage by 1.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #34     +/-   ##
=========================================
+ Coverage   93.96%   95.17%   +1.2%     
=========================================
  Files          25       25             
  Lines        1426     1429      +3     
=========================================
+ Hits         1340     1360     +20     
+ Misses         86       69     -17
Impacted Files Coverage Δ
Tests/LoginViewControllerTests.swift 100% <100%> (+0.69%) ⬆️
Sources/CelyLoginViewController.swift 98.52% <100%> (+1.47%) ⬆️
Cely Demo/AppDelegate.swift 66.66% <100%> (+8.33%) ⬆️
Sources/CelyWindowManager.swift 95.23% <0%> (-4.77%) ⬇️
Sources/Locksmith.swift 97.87% <0%> (+1.59%) ⬆️
Tests/CelyStorageTests.swift 91.3% <0%> (+3.47%) ⬆️
Cely Demo/LoginStyles.swift 86.66% <0%> (+6.66%) ⬆️
Sources/CelyStorage.swift 91.3% <0%> (+10.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a0a99...ff51587. Read the comment docs.

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #34 into master will increase coverage by 1.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #34     +/-   ##
=========================================
+ Coverage   93.96%   95.17%   +1.2%     
=========================================
  Files          25       25             
  Lines        1426     1429      +3     
=========================================
+ Hits         1340     1360     +20     
+ Misses         86       69     -17
Impacted Files Coverage Δ
Tests/LoginViewControllerTests.swift 100% <100%> (+0.69%) ⬆️
Sources/CelyLoginViewController.swift 98.52% <100%> (+1.47%) ⬆️
Cely Demo/AppDelegate.swift 66.66% <100%> (+8.33%) ⬆️
Sources/CelyWindowManager.swift 95.23% <0%> (-4.77%) ⬇️
Sources/Locksmith.swift 97.87% <0%> (+1.59%) ⬆️
Tests/CelyStorageTests.swift 91.3% <0%> (+3.47%) ⬆️
Cely Demo/LoginStyles.swift 86.66% <0%> (+6.66%) ⬆️
Sources/CelyStorage.swift 91.3% <0%> (+10.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a0a99...4a177e9. Read the comment docs.

@initFabian
Copy link
Collaborator

Also updated CI to use new xcode version

@alextall
Copy link
Collaborator Author

Everything looks good here.

@initFabian initFabian merged commit a556b75 into master May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants