-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Swift 4.2 #34
Conversation
Signed-off-by: Alex Du Bois <[email protected]>
Nice! Thanks for knocking this out. I updated documentation and tests for this build. Please review and verify on your machine everything is 👌 |
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
=========================================
+ Coverage 93.96% 95.17% +1.2%
=========================================
Files 25 25
Lines 1426 1429 +3
=========================================
+ Hits 1340 1360 +20
+ Misses 86 69 -17
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
=========================================
+ Coverage 93.96% 95.17% +1.2%
=========================================
Files 25 25
Lines 1426 1429 +3
=========================================
+ Hits 1340 1360 +20
+ Misses 86 69 -17
Continue to review full report at Codecov.
|
Also updated CI to use new xcode version |
Everything looks good here. |
@initFabian The targets were still building against Swift 4.0. I've updated them to 4.2 (which should probably be marked as release 2.1) and will make another PR for 5.0 (which can then be marked as 2.2).