Add batch request limit and response size limit in a RPC batch request #2357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage from tests in coverage: 54.8% of statements across all listed packagescoverage: 68.6% of statements in consensus/istanbul coverage: 63.3% of statements in consensus/istanbul/announce coverage: 57.0% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 65.2% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.2% of statements in consensus/istanbul/uptime coverage: 52.4% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
|
karlb
reviewed
Mar 4, 2025
| // Once total size of responses exceeds an allowed maximum, | ||
| // generate error messages for all remaining calls and stop further processing | ||
| if responseBytes += len(answer.Result); responseBytes > BatchResponseMaxSize { | ||
| for i := idx; i < len(calls); i++ { |
There was a problem hiding this comment.
Since we added one answer above, don't we have to either
- start at
idx +1to reject all the following requests (and live with the fact that we slightly exceededresponseBytes) or - do this check before appending the current
answertoanswers?
gastonponti
reviewed
Mar 4, 2025
| // Once total size of responses exceeds an allowed maximum, | ||
| // generate error messages for all remaining calls and stop further processing | ||
| if responseBytes += len(answer.Result); responseBytes > BatchResponseMaxSize { | ||
| for i := idx; i < len(calls); i++ { |
karlb
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds limitations of number of batch items and response size in JSON-RPC request for avoiding an excessive memory usage.
After this change, a batch request can contain up to a maximum of 1000 requests, and the total size of all result data is limited to 25 MB.
The hardcoded boundary values are based on the default values in the current implementation of go-ethereum.
Other changes
Describe any minor or "drive-by" changes here.
Tested
I added unit tests for each change
Related issues
Backwards compatibility
Brief explanation of why these changes are/are not backwards compatible.