Skip to content

Add deep copy of Difficulty field in types.CopyHeader #2353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

chetna-mittal
Copy link

Description

Add a deep copy of the Difficulty field in types.CopyHeader function.

Resolves: #2309

@palango palango requested a review from piersy February 7, 2025 11:02
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.94%. Comparing base (f0adb14) to head (5fd0de0).
Report is 57 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2353      +/-   ##
==========================================
- Coverage   55.06%   54.94%   -0.12%     
==========================================
  Files         684      685       +1     
  Lines      114596   114965     +369     
==========================================
+ Hits        63097    63164      +67     
- Misses      47617    47895     +278     
- Partials     3882     3906      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@palango
Copy link
Collaborator

palango commented Apr 1, 2025

Thanks for submitting this PR!

Our development now concentrates on op-geth and we'll only fix critical issues in this repository. Please check and submit your PR there.

@palango palango closed this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure we deep copy the difficulty field in types.CopyHeader
2 participants