eth/filter, ethclient/gethclient: added fullTx-flag to NewPendingTransactions #2239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diwu1989
force-pushed
the
port-full-pending-txs
branch
from
88c49e6 to
2dc3c78
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2239 +/- ##
==========================================
+ Coverage 55.06% 55.17% +0.10%
==========================================
Files 683 683
Lines 114533 114538 +5
==========================================
+ Hits 63073 63191 +118
+ Misses 47562 47468 -94
+ Partials 3898 3879 -19 ☔ View full report in Codecov by Sentry. |
…sactions * #24524
diwu1989
force-pushed
the
port-full-pending-txs
branch
from
2dc3c78 to
776aed1
Compare
palango
approved these changes
Jan 31, 2024
|
Coverage from tests in coverage: 50.9% of statements across all listed packagescoverage: 63.2% of statements in consensus/istanbul coverage: 42.8% of statements in consensus/istanbul/announce coverage: 56.0% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 65.1% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.2% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
|
|
|
Thanks for the merge, there's a followup bug fix in ethereum/go-ethereum#26126 that I'll also port over so that the pending RPC transaction JSON is consistent across the different APIs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting https://github.com/ethereum/go-ethereum/pull/25186/files to Celo.
There were some trivial merge conflicts in
eth/filters/api.gothat needed to be resolved before this could apply.Would like this to be merged in and deployed to Forno so that websocket streams from the pub RPC TX pool includes the body, otherwise, there's just extra load doing round trip to fetch via pending tx header.