Notify proxied validator engine of new epoch #1240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevjue
requested review from
mcortesi,
tkporter and
trianglesphere
as code owners
added 2 commits
November 18, 2020 09:50
trianglesphere
pushed a commit
that referenced
this pull request
Nov 18, 2020
* notify proxied validator engine on new peoch * added comment * clarified comment Co-authored-by: Kevin Jue <[email protected]>
mcortesi
pushed a commit
that referenced
this pull request
Nov 19, 2020
* notify proxied validator engine on new peoch * added comment * clarified comment Co-authored-by: Kevin Jue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The proxied validator engine was not being notified of a new epoch, causing that engine to not be aware of any new validator set diffs, and consequently not assigning new validators to it's proxies and never connecting to them.
Other changes
None
Tested
Backwards compatibility
Yes.