Skip to content

chore: parameter constant expression cleanup #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

prestwich
Copy link
Contributor

Description

Improved legibility of Celo-specific constants. In order to avoid breaking compatiblity with upstream, non-Celo-specific params have been left as-is

Tested

Local tests. Would appreciate more manual inspection to be sure all constants are unchanged.

@prestwich prestwich force-pushed the prestwich/param-cleanup branch 2 times, most recently from f288dff to a1a762c Compare September 21, 2020 22:15
@prestwich prestwich force-pushed the prestwich/param-cleanup branch from a1a762c to eb0b158 Compare September 21, 2020 22:15
Copy link
Contributor

@mcortesi mcortesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@mcortesi mcortesi merged commit de0c59c into master Sep 22, 2020
@mcortesi mcortesi deleted the prestwich/param-cleanup branch September 22, 2020 18:48
@mcortesi mcortesi added this to the 1.0.2 milestone Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants