Revert "Separate Etherbase flag by responsibility (#807)" #1134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4c86d8d. # Conflicts: # eth/backend.go
mcortesi
requested review from
asaj,
diminator,
kevjue,
timmoreton and
tkporter
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit #807
The rationale is that #807 implies a hard-fork that is not totally shielded with "minimumClientVersion". It does check it when verifying a block, but it's not taken into account when creating a new block. Which implies that if a validator uses this flags it won't be accepted by other validators.
The intention is to revisit #807 and to include it later.
Tested
CI
Backwards compatibility
Yes