Removing flags and data related to Ethereum testnets #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevjue
reviewed
May 5, 2020
| @@ -238,7 +238,7 @@ func getGenesisAndKeys(n int, isFullChain bool) (*core.Genesis, []*ecdsa.Private | |||
| } | |||
|
|
|||
| // generate genesis block | |||
| genesis := core.DefaultOttomanGenesisBlock() | |||
| genesis := core.DefaultGenesisBlock() | |||
There was a problem hiding this comment.
There seems to be a really big different between the default ottoman genesis block's extra data and the default genesis block's.
Do you know what that difference is?
There was a problem hiding this comment.
Mostly it's the mainnet genesis validators. They are replaced below in AppendValidatorsToGenesisBlock
cmd/devp2p/discv4cmd.go
Outdated
| @@ -181,7 +181,7 @@ func discv4Crawl(ctx *cli.Context) error { | |||
| } | |||
|
|
|||
| func parseBootnodes(ctx *cli.Context) ([]*enode.Node, error) { | |||
| s := params.RinkebyBootnodes | |||
| s := params.AlfajoresBootnodes | |||
There was a problem hiding this comment.
Is there a specific reason why you are using the Alfajores bootnodes here?
There was a problem hiding this comment.
Looks like they just had some default here
| }, | ||
| Threshold: 2, | ||
| } | ||
|
|
||
| // TestnetChainConfig contains the chain parameters to run a node on the Ropsten test network. | ||
| TestnetChainConfig = &ChainConfig{ |
There was a problem hiding this comment.
I think it's used in tests.
kevjue
approved these changes
May 6, 2020
| @@ -33,6 +33,14 @@ var ( | |||
| BaklavaGenesisHash = common.HexToHash("0x09bb180829b78343cc752e110c2ece86dad46904ffad9a5791b3440f140f1d7f") | |||
| ) | |||
|
|
|||
| var ( | |||
| MainnetNetworkId = uint64(42220) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Other changes
Tested
Related issues
Backwards compatibility