Skip to content

Ignore all methods except Close and Close-OK when channel/connection is closing #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2019
Merged

Ignore all methods except Close and Close-OK when channel/connection is closing #280

merged 1 commit into from
Jun 13, 2019

Conversation

matusvalo
Copy link
Member

This PR is adjusting closing Channel and Connection to conform AMQP 0.9.1 specification. Now after sending Close() method on channel (connection) all messages except channel (connection) Close() and Close-OK() are discarded.

@matusvalo
Copy link
Member Author

@auvipy @thedrow would you mind to review the PR?

@matusvalo matusvalo mentioned this pull request Jun 12, 2019
Open
@matusvalo matusvalo force-pushed the connection_channel_close branch 3 times, most recently from 8346b25 to 5ef12bb Compare June 12, 2019 07:59
@autorebase autorebase bot force-pushed the connection_channel_close branch from 5ef12bb to 6547380 Compare June 12, 2019 09:23
@matusvalo matusvalo force-pushed the connection_channel_close branch 2 times, most recently from b28745b to 47655af Compare June 12, 2019 13:39
@matusvalo matusvalo marked this pull request as ready for review June 12, 2019 13:40
@matusvalo matusvalo force-pushed the connection_channel_close branch from 47655af to 4b19d1d Compare June 12, 2019 13:47
@matusvalo matusvalo requested a review from thedrow June 12, 2019 14:21
@matusvalo
Copy link
Member Author

Apicheck is failing in CI. It seems not related to the PR.

@matusvalo matusvalo requested a review from auvipy June 12, 2019 14:22
auvipy
auvipy reviewed Jun 12, 2019
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except the same method used twice, can this be converted in to one?

@matusvalo matusvalo force-pushed the connection_channel_close branch from 4b19d1d to c62b9a9 Compare June 12, 2019 22:44
@autorebase autorebase bot force-pushed the connection_channel_close branch from c62b9a9 to 99ec59c Compare June 13, 2019 15:06
@matusvalo matusvalo merged commit d5c0804 into master Jun 13, 2019
@auvipy auvipy deleted the connection_channel_close branch June 13, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
Component: Channel PR Type: Bugfix Status: Ready For Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matusvalo @auvipy