-
Notifications
You must be signed in to change notification settings - Fork 19
Add / import <mapml-viewer> to gcds under components/gcds-map #759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
69447e5
to
ac94826
Compare
I was testing how it would work in a released form (had only run it inside the project dev environment up to now) and I realized that the path to the mapml.js module was dependent on the dev configuration. So I updated that just now, and it "should work" in an installed environment with this update. Thanks for your review, happy to meet and discuss together, to see if there's more I can do to make it easy to integrate into the next release or so. PR |
2748947
to
743c483
Compare
Closes #773 |
@prushforth thanks for this PR, really appreciate it, and I added a comment to the issue you have opened as well. I'm hoping to have some time next week to start the review, and I can email or message you soon once we have a better sense of the scope of work. |
743c483
to
81c9a96
Compare
Add dependency on @maps4html/mapml Update stencil config to copy mapml to dist output directory. Update index.html with example <mapml-viewer> Add gcds-map.stories.tsx Add dist/gcds/gcds-map as static resource directory for storybook. Make controlslist a multi-select in storybook Make gcds-map a component only in name, created for the purpose of importing the map client CSS rules in gcds-map.css. Add global script to dynamically and conditionally import mapml.js; global script can refer to other global script imports as required. Include gcds-map.css in build, integrate via run time load Add mapml.js and gcds-map.css imports to storybook preview-head.html, so that it appears in the iframe regardless of whether the <mapml-viewer> has been rendered yet. Add some basemap mapml (services) directory contents to component definition for use in index.html and story Add a test Add jest, jest-environment-node to root node_modules - this is necessary to successfully run tests in packages/web Add gcds-map.d.ts, re-export from index.ts. Leverage gcds-map.d.ts in gcds-map.e2e.ts a little bit Fix issue with ts not liking [Symbol.iterator]: function (): IterableIterator<File> by adding dom.iterable to the lib section, fix discovered here: sitelint.com/blog/solution-to-type-filelist-must-have-a-symbol-iterator-method-that-returns-an-iterator Add dom.iterable to tsconfig.json everywhere Add functional second story to map: hidden (basemap) layers. Add current_conditions in en only (so far). Add a Playground story Add geojson default style example Update current weather to comment out feature query Add copying of geojson canada.json file into static assets Update GeoJSON2MapMLExample story with styles. Update GeoJSON2MapMLExample story parameters docs.source.code etc Add DarkMode example with assets Update dark mode example to be remote mapml, so that we can have an explicit inline/remote example later. Update overview, add inline vs remote MapML example Add custom projection example Add delimiter comments to code disclosure widget so that the Copy button works, except for that there's no React code in this component Co-authored-by: Pierre Dubois <[email protected]> Update global-mapml.ts to use import.meta to obtain the module path at runtime, so that mapml.js can be correctly imported at the same root path as gcds-components/dist Add devDependency on babel-plugin-transform-import-meta Add babel-plugin-transform-import-meta to storybook main.js to ignore the import.meta since it is a runtime consideration Update relative paths of resources to get the build-storybook script working Add sass-embedded devDependency so that the npm run build script will work Revert test line from package.json Rebase on upstream main
81c9a96
to
3b1e36f
Compare
Summary | Résumé
Test instructions | Instructions pour tester la modification