This repository was archived by the owner on Jun 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Hybrid Schrödinger-Feynman Simulation Preparation #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ state generation, matrix generation, and multiplication receive an additional parameter `start` (default 0) that indicates the bottom-most qubit the DD is built from 💥 removed the `makeGateDD` constructor taking two `Qubit` arguments for control and target, as it is ambiguous with the new `start` parameter ✨ method for deleting a specific edge of a DD node ✨ `kronecker` receives an additional parameter indicating whether to increase the indices of the top DD ✨ method for tranfering a DD Edge from one package to another ✨ methods for (recursively) exporting and adding amplitudes Signed-off-by: Lukas Burgholzer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
========================================
- Coverage 95.4% 95.3% -0.1%
========================================
Files 17 17
Lines 2274 2290 +16
========================================
+ Hits 2170 2184 +14
- Misses 104 106 +2
Continue to review full report at Codecov.
|
♻️ adjust to removed constructor 🐛 `BM_MakeControlledQubitGateDD_ControlBottom_TargetTop` did not actually construct a controlled operation Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
⬆️ benchmark Signed-off-by: Lukas Burgholzer <[email protected]>
hillmich
suggested changes
May 6, 2021
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
hillmich
approved these changes
May 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done.
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the essential functionality to the JKQ DD Package to support hybrid Schrödinger-Feynman simulation.
The main change is that decision diagrams might now "start" (from the bottom) with a different qubit than 0, which is needed for splitting the circuit horizontally.
Additionally, this PR adds functionality that allows to efficiently export a complete set of amplitudes from a state vector DD and to transfer an existing DD to another package instance.
✨ state generation, matrix generation, and multiplication receive an additional parameter
start
(default 0) that indicates the bottom-most qubit the DD is built from💥 removed the
makeGateDD
constructor taking twoQubit
arguments for control and target, as it is ambiguous with the newstart
parameter✨ method for deleting a specific edge of a DD node
✨
kronecker
receives an additional parameter indicating whether to increase the indices of the top DD✨ method for tranfering a DD Edge from one package to another
✨ methods for (recursively) exporting and adding amplitudes
✨ ComplexValue addition
🏁 fix binary serialization issues under Windows
♻️ runtime exceptions instead of assertions
📝 fix readme example
📄 updated license