-
Notifications
You must be signed in to change notification settings - Fork 11
Integrate Clang-Tidy Workflow for DD Package #104
Conversation
Codecov Report
@@ Coverage Diff @@
## main #104 +/- ##
=======================================
- Coverage 95.8% 95.5% -0.3%
=======================================
Files 20 20
Lines 3800 3844 +44
=======================================
+ Hits 3641 3674 +33
- Misses 159 170 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
- fix tidy warning for test_package.cpp
cb52ec5
to
d270d1c
Compare
- also corrected Edge.hpp
- Maybe enable again later
- remove old linter from workflow - fix some warnings
- We really should split this file into multiple files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the changes! It's great to see consistency across the repository.
I got a couple of minor comments/requests.
Yet to make it through the Package.hpp file. Expect another review of that file soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just finished going through the leftover file. Only two small questions/comments there. Overall there should not be much to address here 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼 Thanks for pushing this!
This PR introduces a new CI job to check for compliance via Clang Tidy.
This includes checking variable and function names, warnings for C-style casts and a few more.
(Recreated from #103)