Skip to content
This repository was archived by the owner on Jun 15, 2023. It is now read-only.

Integrate Clang-Tidy Workflow for DD Package #104

Merged
merged 44 commits into from
Sep 12, 2022
Merged

Integrate Clang-Tidy Workflow for DD Package #104

merged 44 commits into from
Sep 12, 2022

Conversation

hillmich
Copy link
Collaborator

This PR introduces a new CI job to check for compliance via Clang Tidy.

This includes checking variable and function names, warnings for C-style casts and a few more.

(Recreated from #103)

@hillmich hillmich added the enhancement New feature or request label Aug 31, 2022
@hillmich hillmich self-assigned this Aug 31, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #104 (b5bbcad) into main (7bf880a) will decrease coverage by 0.2%.
The diff coverage is 95.5%.

@@           Coverage Diff           @@
##            main    #104     +/-   ##
=======================================
- Coverage   95.8%   95.5%   -0.3%     
=======================================
  Files         20      20             
  Lines       3800    3844     +44     
=======================================
+ Hits        3641    3674     +33     
- Misses       159     170     +11     
Impacted Files Coverage Δ
include/dd/Complex.hpp 100.0% <ø> (ø)
include/dd/Edge.hpp 100.0% <ø> (ø)
include/dd/GateMatrixDefinitions.hpp 100.0% <ø> (ø)
include/dd/UnaryComputeTable.hpp 95.2% <75.0%> (-4.8%) ⬇️
include/dd/DensityNoiseTable.hpp 93.3% <80.0%> (-6.7%) ⬇️
include/dd/ComplexValue.hpp 96.6% <81.2%> (-0.8%) ⬇️
include/dd/ComputeTable.hpp 96.5% <88.8%> (+0.5%) ⬆️
include/dd/Package.hpp 91.8% <90.9%> (-0.2%) ⬇️
include/dd/ToffoliTable.hpp 97.5% <92.3%> (-2.5%) ⬇️
include/dd/Export.hpp 95.8% <96.8%> (-0.4%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hillmich hillmich requested a review from burgholzer September 9, 2022 12:13
@hillmich hillmich marked this pull request as ready for review September 9, 2022 12:34
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes! It's great to see consistency across the repository.
I got a couple of minor comments/requests.

Yet to make it through the Package.hpp file. Expect another review of that file soon.

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just finished going through the leftover file. Only two small questions/comments there. Overall there should not be much to address here 👍🏻

@hillmich hillmich requested a review from burgholzer September 12, 2022 06:47
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 Thanks for pushing this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants