This repository was archived by the owner on Jun 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¬οΈ benchmark Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
β‘ reference instead of copy on getting nodes from any table Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
β¦d for by a `dd::Qubit` alone Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
β¨ formatted matrix printing Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
======================================
Coverage 96.1% 96.1%
======================================
Files 16 17 +1
Lines 2220 2262 +42
======================================
+ Hits 2134 2175 +41
- Misses 86 87 +1
Continue to review full report at Codecov.
|
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
β¦n using (Apple)Clang under macOS Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
β¦d_list` to explicitly batch-allocated `next` members in the respective table entry classes π¨ optimize header includes Signed-off-by: Lukas Burgholzer <[email protected]>
β¦nger needed Signed-off-by: Lukas Burgholzer <[email protected]>
β¦bage collection Signed-off-by: Lukas Burgholzer <[email protected]>
β‘ if any unique/complex table needs to be garbage collected, collect all of them at once in order to minimize compute table invalidations β‘ adjust garbage collection limit depending on the number of remaining entries β‘ reduce initial garbage collection limits π₯ remove unused GC_INCREMENT Signed-off-by: Lukas Burgholzer <[email protected]>
β¦f Clang Signed-off-by: Lukas Burgholzer <[email protected]>
β small coverage increase Signed-off-by: Lukas Burgholzer <[email protected]>
β¦endence. llvm stdlib used IEEE FP representation as hash for double, which turns out to be a bad idea. So is hashing floating points in general. β‘ further tweak garbage collection β‘ reduce default size of some compute tables in order to conserve space π revert to using Clang for CI Signed-off-by: Lukas Burgholzer <[email protected]>
β¦ changed hash function Signed-off-by: Lukas Burgholzer <[email protected]>
π‘ documentation for hash functions Signed-off-by: Lukas Burgholzer <[email protected]>
β¦to be slightly altered Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
β‘ complex table hash now rounds instead of truncates the calculated value β‘ introduce additional 1/sqrt(2) static member in complex table β‘π always check 0, 1/sqrt(2), and 1 first upon accessing the respective buckets in the complex table Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
β¦lidation Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
hillmich
suggested changes
Apr 26, 2021
π change garbage collection limit calculation to avoid overflow π renaming `needsCollection` to `possiblyNeedsCollection` β¬οΈ googletest β¬οΈ benchmark β‘ toffoli table and identity table need not be cleared when complex numbers have been collected as the just consist of edges with weight 1 Signed-off-by: Lukas Burgholzer <[email protected]>
hillmich
approved these changes
Apr 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some of the bugs and obstacles that came up when integrating the new package version into our QFR library.
stack
andforward_list
to dedicatednext
pointers that are pre-allocated with the entriescolorFromPhase
when a negative phase was encounteredComplexTable::Entry
Complex
toComplexValue