Skip to content

Dev/atomsbase integration #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 2, 2023
Merged

Dev/atomsbase integration #18

merged 14 commits into from
Aug 2, 2023

Conversation

vcanogil
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a14e987) 100.00% compared to head (9986d5c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         3    +1     
  Lines           25        30    +5     
=========================================
+ Hits            25        30    +5     
Files Changed Coverage Δ
src/Cclib.jl 100.00% <ø> (ø)
src/ab_integration.jl 100.00% <100.00%> (ø)
src/functions.jl 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vcanogil vcanogil marked this pull request as ready for review July 27, 2023 23:09
@vcanogil
Copy link
Collaborator Author

vcanogil commented Jul 29, 2023

This is ready to be merged whenever you are ready.

Copy link
Member

@berquist berquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stuff, I can confirm this is working.

@vcanogil vcanogil requested a review from berquist July 31, 2023 16:02
Copy link
Member

@shivupa shivupa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more minor changes sorry

@vcanogil vcanogil requested a review from shivupa August 1, 2023 17:31
@vcanogil vcanogil dismissed berquist’s stale review August 2, 2023 21:56

Resolved as per Shiv's comments

@vcanogil vcanogil merged commit b84e81f into main Aug 2, 2023
@vcanogil vcanogil deleted the dev/atomsbase_integration branch August 2, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants