Block MapColor metadata provider for block inspection #2164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
BlockDetails
to provide the MapColor of the block in question. Here is a demo program, which when run on a turtle, will change the color of the screen to the MapColor of the block in front of the turtle:I don't personally have a usecase in mind for this yet, but someone in the discord asked if they could get the color of a block through
turtle.inspect
, and it peaked my curiosity.This PR only adds this for Block inspection because
BlockState:getMapColor
takes in aLevel
andBlockPos
as arguments. For experimentation's sake I passednull, null
in and confirmed that works for getting the MapColor of blocks while they are in the inventory. However, the function args are not annotated as Nullable, and may theoretically be used in some places. Also the Fabric version refuses to build (because of the null checker). So for the sake of compatibility, this is only for blocks placed in-world.I also feel a little weird directly accessing the
.col
member ofMapColor
, but theMapColor:calculateRGBValue
function appears to or the RGB values with a magic number, resulting in the incorrect colors.