Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: interval scope resolver #49

Merged
merged 9 commits into from
Dec 7, 2022
Merged

feat!: interval scope resolver #49

merged 9 commits into from
Dec 7, 2022

Conversation

cbochs
Copy link
Owner

@cbochs cbochs commented Dec 7, 2022

Changes

  • BREAKING Move builtin scope resolvers to require("grapple").resolvers
    • From require("grapple.scope").resolvers
    • If you were using the name of a builtin scope resolver, you should't be impacted
  • BREAKING Scope resolver keys are now internal
    • Remove key from Grapple.ScopeOptions
    • Only builtin scope resolvers can be accessed by name
  • FEATURE The cache option when creating a scope resolver now accepts a number (in milliseconds)
  • INCOMPLETE (wip) add ability to create an asynchronous scope resolver (i.e. git branch)
  • Fix issue where builtin scope resolvers were being cleared before setup
  • Update README

@cbochs cbochs merged commit 6c77aba into main Dec 7, 2022
@cbochs cbochs mentioned this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant