-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add keymaps for floating window #174
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very excited about this new feature!
@cbochs friendly bump :)) |
@tronikelis apologies for the late reply. I was away on vacation for the past several weeks. Will take a look here soon 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start to making mappings more customizable! Left a couple comments.
One note: I think (at least for now) I would prefer that the go_up_scope
be fixed. It doesn't have a good common action between the different windows. For example, Tags -> Scopes, Scopes -> Loaded (containers), Loaded (containers) -> Scopes.
It almost feels like there should be separate maps for each:
tag_mappings = { go_to_scopes = "-" }
scope_mappings = { go_to_loaded = "-" }
loaded_mappings = { go_to_scopes = "-" }
But needs a bit more thought, I think. In addition, I don't really like the name loaded
. It obscures what is this window is really for: Grapple containers. Something I would like to resolve in the near future would be to rename this from "loaded" to "containers".
|
||
--Override default floating window mappings | ||
win_mappings = { | ||
toggle_hidden = "g.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some action name change suggestions:
unload_scope
->unload
and put in theloaded_mappings
tablereset_scope
->reset
and put in theloaded_mappings
tablechange_scope
->change
and put in thescope_mappings
tableselect_horizontal
->select_split
and put in thetag_mappings
tableselect_vertical
->select_vsplit
and put in thetag_mappings
table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the insights, I'll change it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you list all the renames here? Or is something left
@cbochs I've changed the names based on your comments, please check if I got everything right |
@cbochs could we get this merged? |
@cbochs 🥲 |
closes #172
I am up for discussion on how to call these settings and where to put them
fyi I tested the changes locally
Another approach would be to architecture settings like this:
Not really sure which one's betteer