Skip to content

[BUG] Holding down 'w' to review fast throws an error #2296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
acardona opened this issue Mar 14, 2025 · 1 comment
Open

[BUG] Holding down 'w' to review fast throws an error #2296

acardona opened this issue Mar 14, 2025 · 1 comment
Labels
status: done type: defect

Comments

@acardona
Copy link
Contributor

I am using '2' for Virtual node step.

The error happens after a second or two of holding down 'w'.

Can not find intersection between node 1706431 and 1706430 at Z = 9149

Click to show/hide detail (please include in bug reports)

Version: 2021.12.21.dev0+unknown
Error
    at CATMAID.Error [as constructor] (https://neurophyla.mrc-lmb.cam.ac.uk/catmaid/fibsem/static/js/libs/catmaid-lib.29d65230bd43.js:20:19)
    at new CATMAID.ValueError (https://neurophyla.mrc-lmb.cam.ac.uk/catmaid/fibsem/static/js/libs/catmaid-lib.29d65230bd43.js:36:19)
    at CATMAID._createVirtualNode (https://neurophyla.mrc-lmb.cam.ac.uk/catmaid/fibsem/static/js/catmaid.c776e4d0210d.js:93126:13)
    at CATMAID.createVirtualNode (https://neurophyla.mrc-lmb.cam.ac.uk/catmaid/fibsem/static/js/catmaid.c776e4d0210d.js:93104:20)
    at https://neurophyla.mrc-lmb.cam.ac.uk/catmaid/fibsem/static/js/catmaid.c776e4d0210d.js:93633:30
    at async Promise.all (index 0)
tomka added a commit that referenced this issue Mar 26, 2025
@tomka
Review widget: fix error about missing intersection between nodes
fc27c51 
The parent node's zdiff (relative distance to current Z) refers to the Z
of its initial creation. Sometimes virtual nodes are possibly created
for other Zs. Since the stored zdiff is wrong in those cases, it must
computed on the fly. This is what this commit adds. With "wrong" parent
zdiffs, an error like "Can not find intersection between node 1706431
and 1706430 at Z = 9149" could appear in rare cases.

Fixes #2296
@tomka
Copy link
Contributor

tomka commented Mar 26, 2025

This should be fixed now in dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: done type: defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@acardona @tomka