Skip to content

[BUG] Review system update issue #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acardona opened this issue Jan 10, 2025 · 5 comments
Open

[BUG] Review system update issue #2280

acardona opened this issue Jan 10, 2025 · 5 comments

Comments

@acardona
Copy link
Contributor

When deleting a node, the review widget will refresh the tables, without considering whether the revision was for the whole arbour or just for a subarbor. So one starts reviewing a subarbor, deletes a node, and the review tables change completely to include the whole arbour.

@acardona
Copy link
Contributor Author

Also, closing the Review widget throws an error.

@acardona
Copy link
Contributor Author

And once closed it can't be reopened again. The javascript console throws errors: "cannot read properties of undefined (reading 'EVENT_NODE_DELETED'), in the ReviewSystem.destroy() method.

@acardona
Copy link
Contributor Author

Furthermore, upon deleting a skeleton treenode, the view is repositioned to the last node of the segment (the first to review). Frankly the view should not move at all, it gets in the way a lot.

@tomka
Copy link
Contributor

tomka commented Feb 10, 2025

And once closed it can't be reopened again. The javascript console throws errors: "cannot read properties of undefined (reading 'EVENT_NODE_DELETED'), in the ReviewSystem.destroy() method.

This is fixed now in dev.

tomka added a commit that referenced this issue Feb 10, 2025
@tomka
Copy link
Contributor

tomka commented Feb 10, 2025

So one starts reviewing a subarbor, deletes a node, and the review tables change completely to include the whole arbour.

This is fixed in dev as well. The review table is now updated so that it respects any active sub-arbor review.

Furthermore, upon deleting a skeleton treenode, the view is repositioned to the last node of the segment (the first to review). Frankly the view should not move at all, it gets in the way a lot.

The view is now also not repositioned anymore after a node deletion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants