Skip to content

style: remove redundant override specifier from functions that are declared final #2989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2025

Conversation

e-kwsm
Copy link
Contributor

@e-kwsm e-kwsm commented Jun 9, 2025

Description

clang-tidy complains about unnecessary override as per modernize-use-override.

Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.98%. Comparing base (65cd203) to head (c813bc4).

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2989      +/-   ##
==========================================
- Coverage   91.01%   90.98%   -0.03%     
==========================================
  Files         198      198              
  Lines        8599     8599              
==========================================
- Hits         7826     7823       -3     
- Misses        773      776       +3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisThrasher ChrisThrasher force-pushed the modernize-use-override branch from 1f3c68f to 5845eb3 Compare June 14, 2025 15:33
@ChrisThrasher ChrisThrasher force-pushed the modernize-use-override branch from 5845eb3 to c813bc4 Compare June 14, 2025 17:47
@ChrisThrasher ChrisThrasher merged commit 1de7d0e into catchorg:devel Jun 15, 2025
92 checks passed
@e-kwsm e-kwsm deleted the modernize-use-override branch June 15, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants