-
Notifications
You must be signed in to change notification settings - Fork 8
Fix: URL Implementation to handle endpoints and base url. #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes involve modifications to the constructors of several classes, specifically Changes
Sequence Diagram(s)sequenceDiagram
participant C as Client
participant O as OrdersProvider
participant U as Url
C->>O: new OrdersProvider(urlString)
O->>U: new Url(urlString)
O->>U: call endpoint("orders")
sequenceDiagram
participant C as Client
participant B as BlockNumberFetcher
participant U as Url
C->>B: new BlockNumberFetcher(url, network)
B->>U: new Url(url)
B->>U: call endpoint("blocknumber")
B->>U: call endpoint(network)
sequenceDiagram
participant C as Client
participant E as EvmRelay
participant U as Url
C->>E: new EvmRelay(url, auth)
E->>U: new Url(url)
E->>U: call endpoint("relayer")
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary by CodeRabbit
Refactor
Chores
@gardenfi/core
package from2.0.22
to2.0.23
.@gardenfi/orderbook
package from2.0.6
to2.0.7
.@gardenfi/react-hooks
package from2.0.26
to2.0.27
.