-
Notifications
You must be signed in to change notification settings - Fork 3
Fix for latlon grid cases #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cassidymwagner
wants to merge
13
commits into
main
Choose a base branch
from
latlon_sepdist
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve latlon grid support.
It's been challenging to test this. So far I've tried to reproduce the linear 2D example to show scaling with$r^2$ and $r^3$ . It seems to match relatively well if I set the latitude and longitude arrays to vary from 0 to 1m, similar to the 0 to 1 code units range in the original example. But if I use a larger range of lats/lons, the amplitudes change a lot. Each SF still scales with $r^2$ and $r^3$ as before, but the factors are different, especially for the advective SF which becomes much smaller with a larger range of lats/lons. I expect that this is because of the advection/gradient calculation since dx/dy is now much larger (keeping nx/ny the same). Find the example notebook here, relevant figure below.
I've also included two new examples
Note: this PR is a duplicate of #29 which was closed when #23 was merged into main.
