Skip to content

Use carvel setup action in test-kctrl-gh #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Use carvel setup action in test-kctrl-gh #945

merged 1 commit into from
Oct 20, 2022

Conversation

praveenrewar
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?

NONE

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


Copy link
Contributor

@100mik 100mik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@100mik 100mik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant... ^

@praveenrewar praveenrewar merged commit 519ecab into develop Oct 20, 2022
@praveenrewar praveenrewar deleted the kctrl-gh branch October 20, 2022 16:06
@praveenrewar praveenrewar added the cli Issue for kapp-controller cli label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required cli Issue for kapp-controller cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants